Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHR QS dealer schema updates #65

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

doug-lovett
Copy link
Collaborator

Issue #: /bcgov/entity#24172

Description of changes:

  • Update document ID length from 8 to 10 in all schemas.
  • Add confirmRequirements, locationAddress to MHR qualified supplier schema.
  • Update unit tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the registry-schemas license (Apache 2.0).

Signed-off-by: Doug Lovett <doug@diamante.ca>
@doug-lovett doug-lovett self-assigned this Nov 12, 2024
Comment on lines +47 to +54
},
"confirmRequirements": {
"type": "boolean",
"description": "Applies to QS dealers: indicates that the dealer has confirmed acceptance of additional requirements regarding registrations."
},
"locationAddress": {
"$ref": "https://bcrs.gov.bc.ca/.well_known/schemas/common/address",
"description": "Applies to QS dealers: specifies the location address for transport permit related registrations."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thank you!

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

Copy link

@flutistar flutistar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@doug-lovett doug-lovett merged commit 45058d6 into bcgov:main Nov 12, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants