Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHR transfer owner edit information #66

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

doug-lovett
Copy link
Collaborator

@doug-lovett doug-lovett commented Nov 14, 2024

Issue #: /bcgov/entity#24303

Description of changes:

  • add previousOwnerId to owner schema.
  • add deleteOwnerGroup schema to skip owner validation on deleted owner groups.
  • Update unit tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the registry-schemas license (Apache 2.0).

Signed-off-by: Doug Lovett <doug@diamante.ca>
@doug-lovett doug-lovett self-assigned this Nov 14, 2024
Signed-off-by: Doug Lovett <doug@diamante.ca>
Signed-off-by: Doug Lovett <doug@diamante.ca>
"previousOwnerId": {
"type": "integer",
"minimum": 1,
"description": "Optional for an addOwnerGroups owner, used in transfer registrations to indicate the owner information has been changed except for the name. In other words, the previousOwnerId in an an addOwnerGroups owner maps to an ownerId in a deleteOwnerGroups owner and the names must be identical."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you!

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

@flutistar flutistar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doug-lovett doug-lovett merged commit 69ce55b into bcgov:main Nov 15, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants