DF-1758 : DF Error Code and moved the model file to common folder #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratheesh-aot
changed the title
Removed all other models.py
ratheesh-aot
force-pushed
the
fix/CommonModelTable
branch
from
6666736
to
6b1b416
Compare
rsbc-roadside-forms-task-scheduler:latest (redhat 8.10) - Trivy Report - 2024-09-23 23:35:33.657045224 +0000 UTC m=+0.329827775
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-form-handler:latest (redhat 8.10) - Trivy Report - 2024-09-23 23:35:50.441901963 +0000 UTC m=+0.354318503
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-backend-api:latest (redhat 8.10) - Trivy Report - 2024-09-23 23:36:02.830075324 +0000 UTC m=+0.354184535
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-form-handler:latest (redhat 8.10) - Trivy Report - 2024-09-24 16:48:18.866931878 +0000 UTC m=+0.364991352
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-task-scheduler:latest (redhat 8.10) - Trivy Report - 2024-09-24 16:55:33.50214586 +0000 UTC m=+0.378446661
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-backend-api:latest (redhat 8.10) - Trivy Report - 2024-09-24 16:55:36.286716859 +0000 UTC m=+0.351866597
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-backend-api:latest (redhat 8.10) - Trivy Report - 2024-09-24 17:05:13.407269371 +0000 UTC m=+0.333968654
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-task-scheduler:latest (redhat 8.10) - Trivy Report - 2024-09-24 17:05:25.757238115 +0000 UTC m=+0.343351661
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-form-handler:latest (redhat 8.10) - Trivy Report - 2024-09-24 17:13:07.75353545 +0000 UTC m=+0.347161166
|
||||||||||||||||||||||||||||||||||||
adimar-aot
requested changes
Sep 24, 2024
rsbc-roadside-forms-form-handler:latest (redhat 8.10) - Trivy Report - 2024-09-25 17:01:03.775837104 +0000 UTC m=+0.324934714
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-backend-api:latest (redhat 8.10) - Trivy Report - 2024-09-25 17:01:15.833014855 +0000 UTC m=+0.335778982
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-task-scheduler:latest (redhat 8.10) - Trivy Report - 2024-09-25 17:04:22.454791029 +0000 UTC m=+0.333885102
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-task-scheduler:latest (redhat 8.10) - Trivy Report - 2024-09-26 00:24:49.038772279 +0000 UTC m=+0.333935417
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-backend-api:latest (redhat 8.10) - Trivy Report - 2024-09-26 00:25:15.291708889 +0000 UTC m=+0.351714533
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-form-handler:latest (redhat 8.10) - Trivy Report - 2024-09-26 00:33:32.708197938 +0000 UTC m=+0.369333388
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-task-scheduler:latest (redhat 8.10) - Trivy Report - 2024-09-26 17:29:21.508997643 +0000 UTC m=+0.342315276
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-backend-api:latest (redhat 8.10) - Trivy Report - 2024-09-26 17:29:44.08004818 +0000 UTC m=+0.360310408
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-form-handler:latest (redhat 8.10) - Trivy Report - 2024-09-26 17:43:37.183461193 +0000 UTC m=+0.336736196
|
||||||||||||||||||||||||||||||||||||
|
rsbc-roadside-forms-task-scheduler:latest (redhat 8.10) - Trivy Report - 2024-09-26 19:01:54.559071537 +0000 UTC m=+0.336021132
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-form-handler:latest (redhat 8.10) - Trivy Report - 2024-09-26 19:02:02.574412055 +0000 UTC m=+0.359684446
|
||||||||||||||||||||||||||||||||||||
rsbc-roadside-forms-backend-api:latest (redhat 8.10) - Trivy Report - 2024-09-26 19:02:11.172534203 +0000 UTC m=+0.337370663
|
||||||||||||||||||||||||||||||||||||
adimar-aot
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#: https://jag.gov.bc.ca/jirarsi/browse/DF-1758
Created error model and table in Digital forms to track errors
Defined basic error code enums (only in python side, in db its all string fields for better filtering capabilities)
Integrated code for recording error to DF Error table
Updated all three services: prohibition, form_handler and task scheduler
Moved the model file to common folder and changed the import of all the three services to use it form common
previously the replace all the three seperate dupicate copy of model with the updated model in prohibition svc
Updated the docker files
Sample error
Unit test added to test the error handling part
https://github.com/bcgov/rsbc-digital-forms/blob/5853654d734b8fa17db1e144263b6886986552c2/python/common/tests/record_error/test_record_error.py