Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17057 - Checking for Authentication Endpoint for Entities #2520

Merged

Conversation

rodrigo-barraza
Copy link
Collaborator

Issue #:17057
bcgov/entity#17057

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #2520 (c8864d2) into main (261dc17) will increase coverage by 9.04%.
Report is 46 commits behind head on main.
The diff coverage is 88.41%.

@@            Coverage Diff             @@
##             main    #2520      +/-   ##
==========================================
+ Coverage   80.71%   89.76%   +9.04%     
==========================================
  Files         322      161     -161     
  Lines       11915     8517    -3398     
  Branches      618        0     -618     
==========================================
- Hits         9617     7645    -1972     
+ Misses       2289      872    -1417     
+ Partials        9        0       -9     
Flag Coverage Δ
accountmailerqueue ?
activityloglistenerqueue ?
authapi 89.76% <88.41%> (-0.20%) ⬇️
authweb ?
eventlistenerqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...th-api/src/auth_api/models/product_subscription.py 100.00% <ø> (ø)
...uth-api/src/auth_api/resources/v1/notifications.py 73.91% <73.91%> (ø)
...i/src/auth_api/resources/v1/documents_affidavit.py 80.00% <80.00%> (ø)
auth-api/src/auth_api/resources/v1/org.py 81.93% <81.93%> (ø)
auth-api/src/auth_api/resources/v1/products.py 90.00% <84.61%> (ø)
...-api/src/auth_api/models/affiliation_invitation.py 92.08% <85.41%> (-5.33%) ⬇️
...pi/src/auth_api/services/affiliation_invitation.py 82.60% <86.39%> (-3.17%) ⬇️
auth-api/src/auth_api/resources/v1/invitation.py 86.81% <86.81%> (ø)
auth-api/src/auth_api/resources/v1/task.py 86.88% <86.88%> (ø)
...rc/auth_api/resources/v1/affiliation_invitation.py 87.14% <87.14%> (ø)
... and 38 more

... and 158 files with indirect coverage changes

@rodrigo-barraza rodrigo-barraza changed the title Checking for Authentication Endpoint for Entities 17057 - Checking for Authentication Endpoint for Entities Sep 5, 2023
@seeker25
Copy link
Collaborator

seeker25 commented Sep 5, 2023

Jumped the gun on that approve

Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests / lints

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 merged commit af1f8f0 into bcgov:main Sep 6, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants