Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14137 - Update API spec to include SETTLEMENT_SCHED #1006

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Nov 2, 2022

Issue #:
bcgov/entity#14137

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 requested a review from ritvick as a code owner November 2, 2022 20:36
@seeker25 seeker25 changed the title Update API spec to include SETTLEMENT_SCHED 14137 - Update API spec to include SETTLEMENT_SCHED Nov 2, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 added the documentation documentation changes label Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #1006 (38a4e23) into main (bca253f) will decrease coverage by 0.07%.
The diff coverage is 93.15%.

@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
- Coverage   91.04%   90.96%   -0.08%     
==========================================
  Files         165      145      -20     
  Lines        9576     9544      -32     
==========================================
- Hits         8718     8682      -36     
- Misses        858      862       +4     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi 92.89% <95.40%> (+0.16%) ⬆️
paymentjobs 79.27% <91.26%> (-0.50%) ⬇️
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jobs/payment-jobs/tasks/cfs_bank_name_updater.py 0.00% <0.00%> (ø)
.../payment-jobs/tasks/statement_notification_task.py 31.81% <0.00%> (ø)
pay-api/src/pay_api/models/invoice_reference.py 100.00% <ø> (ø)
pay-api/src/pay_api/models/routing_slip.py 95.96% <0.00%> (-0.91%) ⬇️
pay-api/src/pay_api/services/paybc_service.py 80.00% <ø> (ø)
pay-api/src/pay_api/services/fas/routing_slip.py 75.79% <75.00%> (+0.10%) ⬆️
...ent-jobs/tasks/direct_pay_automated_refund_task.py 86.51% <86.51%> (ø)
pay-api/src/pay_api/services/flags.py 89.28% <89.28%> (ø)
jobs/payment-jobs/tasks/distribution_task.py 97.70% <96.96%> (+60.20%) ⬆️
jobs/payment-jobs/tasks/cfs_create_invoice_task.py 73.25% <100.00%> (+0.31%) ⬆️
... and 79 more

@seeker25 seeker25 merged commit 8887774 into bcgov:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants