Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14092 - Use decimals for Invoices / Payment Line Items / Payment Accounts / Fees - Part 2 #1008

Merged
merged 5 commits into from
Nov 8, 2022

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Nov 8, 2022

No description provided.

@seeker25 seeker25 requested a review from ritvick as a code owner November 8, 2022 01:02
@seeker25 seeker25 changed the title Float fix part2 14092 - Use decimals for Invoices / Payment Line Items / Payment Accounts / Fees - Part 2 Nov 8, 2022
@seeker25 seeker25 requested a review from kialj876 November 8, 2022 01:02
@seeker25 seeker25 added the bug Something isn't working label Nov 8, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #1008 (c770bfb) into main (bca253f) will decrease coverage by 0.04%.
The diff coverage is 93.86%.

@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
- Coverage   91.04%   90.99%   -0.05%     
==========================================
  Files         165      160       -5     
  Lines        9576    10441     +865     
==========================================
+ Hits         8718     9501     +783     
- Misses        858      940      +82     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue 81.63% <100.00%> (+0.78%) ⬆️
payadmin ∅ <ø> (?)
payapi 92.98% <96.71%> (+0.25%) ⬆️
paymentjobs 79.27% <91.30%> (-0.50%) ⬇️
paymentreconciliationsqueue 91.55% <88.67%> (?)
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jobs/payment-jobs/tasks/cfs_bank_name_updater.py 0.00% <0.00%> (ø)
.../payment-jobs/tasks/statement_notification_task.py 31.81% <0.00%> (ø)
pay-api/src/pay_api/models/invoice_reference.py 100.00% <ø> (ø)
pay-api/src/pay_api/models/routing_slip.py 95.96% <0.00%> (-0.91%) ⬇️
...ent-reconciliations/src/reconciliations/version.py 0.00% <0.00%> (ø)
pay-api/src/pay_api/services/fas/routing_slip.py 75.79% <75.00%> (+0.10%) ⬆️
...ons/src/reconciliations/payment_reconciliations.py 91.73% <83.33%> (ø)
...ent-jobs/tasks/direct_pay_automated_refund_task.py 86.51% <86.51%> (ø)
pay-api/src/pay_api/utils/json_util.py 87.50% <87.50%> (ø)
pay-api/src/pay_api/services/flags.py 89.28% <89.28%> (ø)
... and 100 more

@seeker25 seeker25 merged commit 94df36d into bcgov:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants