Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "14180 - Reverse CSO specific changes for service_fees."" #1021

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

seeker25
Copy link
Collaborator

Reverts #1019

@seeker25 seeker25 requested a review from ritvick as a code owner November 22, 2022 23:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1021 (ad3cccc) into main (bca253f) will increase coverage by 2.99%.
The diff coverage is 96.72%.

@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
+ Coverage   91.04%   94.03%   +2.99%     
==========================================
  Files         165      127      -38     
  Lines        9576     8203    -1373     
==========================================
- Hits         8718     7714    -1004     
+ Misses        858      489     -369     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi 94.03% <96.72%> (+1.30%) ⬆️
paymentjobs ?
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pay-api/src/pay_api/models/invoice_reference.py 100.00% <ø> (ø)
pay-api/src/pay_api/models/routing_slip.py 95.96% <0.00%> (-0.91%) ⬇️
pay-api/src/pay_api/services/fas/routing_slip.py 75.79% <75.00%> (+0.10%) ⬆️
pay-api/src/pay_api/utils/json_util.py 87.50% <87.50%> (ø)
pay-api/src/pay_api/services/flags.py 89.28% <89.28%> (ø)
pay-api/src/pay_api/__init__.py 89.47% <100.00%> (+0.58%) ⬆️
pay-api/src/pay_api/config.py 99.34% <100.00%> (+0.02%) ⬆️
pay-api/src/pay_api/exceptions/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/account_fee.py 100.00% <100.00%> (ø)
... and 92 more

@seeker25 seeker25 merged commit 8a0ce69 into main Nov 23, 2022
@seeker25 seeker25 deleted the revert-1019-revert-1015-14180 branch March 28, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants