Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14435 - Minor change to PAD job that should fix cfs_account_id being blank. T… #1025

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Nov 29, 2022

…his happens when user switches from PAD to BCOL.

Issue #:
bcgov/entity#14435

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

…his happens when user switches from PAD to BCOL.
@seeker25 seeker25 changed the title Minor change to PAD job that should fix cfs_account_id being blank. T… 14435 - Minor change to PAD job that should fix cfs_account_id being blank. T… Nov 29, 2022
@seeker25 seeker25 added the bug Something isn't working label Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1025 (664d06d) into main (bca253f) will decrease coverage by 11.94%.
The diff coverage is 88.79%.

❗ Current head 664d06d differs from pull request most recent head 6f94080. Consider uploading reports for the commit 6f94080 to get more accurate results

@@             Coverage Diff             @@
##             main    #1025       +/-   ##
===========================================
- Coverage   91.04%   79.09%   -11.95%     
===========================================
  Files         165       19      -146     
  Lines        9576     1373     -8203     
===========================================
- Hits         8718     1086     -7632     
+ Misses        858      287      -571     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi ?
paymentjobs 79.09% <88.79%> (-0.68%) ⬇️
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jobs/payment-jobs/tasks/cfs_bank_name_updater.py 0.00% <0.00%> (ø)
.../payment-jobs/tasks/statement_notification_task.py 31.81% <0.00%> (ø)
jobs/payment-jobs/tasks/cfs_create_invoice_task.py 72.68% <75.00%> (-0.27%) ⬇️
...ent-jobs/tasks/direct_pay_automated_refund_task.py 86.51% <86.51%> (ø)
jobs/payment-jobs/tasks/distribution_task.py 97.70% <96.96%> (+60.20%) ⬆️
jobs/payment-jobs/tasks/common/cgi_ap.py 90.78% <100.00%> (ø)
jobs/payment-jobs/tasks/common/cgi_ejv.py 100.00% <100.00%> (ø)
jobs/payment-jobs/tasks/common/dataclasses.py 100.00% <100.00%> (ø)
jobs/payment-jobs/tasks/common/enums.py 100.00% <100.00%> (ø)
jobs/payment-jobs/tasks/ejv_payment_task.py 96.46% <100.00%> (+0.30%) ⬆️
... and 157 more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 merged commit 71958e5 into bcgov:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants