Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for BCOL_Service to allow override for staff fee code #1028

Merged
merged 4 commits into from
Dec 2, 2022

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Dec 2, 2022

Issue #:
bcgov/entity#14010

Description of changes:
Changes to allow overriding staff bcol fee code. This way we can reuse the code from a jupyter notebook to recreate BCOL transactions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

…e the code from a jupyter notebook to recreate BCOL transactions.
@seeker25 seeker25 requested review from ritvick and Jxio as code owners December 2, 2022 19:44
@seeker25 seeker25 added the enhancement New feature or request label Dec 2, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #1028 (ddf29fb) into main (031986a) will increase coverage by 12.78%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #1028       +/-   ##
===========================================
+ Coverage   79.11%   91.89%   +12.78%     
===========================================
  Files          19      146      +127     
  Lines        1374     9589     +8215     
===========================================
+ Hits         1087     8812     +7725     
- Misses        287      777      +490     
Flag Coverage Δ
payapi 94.03% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pay-api/src/pay_api/services/bcol_service.py 89.02% <100.00%> (ø)
...ay-api/src/pay_api/services/payment_transaction.py 96.55% <0.00%> (ø)
pay-api/src/pay_api/models/ejv_header.py 100.00% <0.00%> (ø)
pay-api/src/pay_api/models/audit.py 100.00% <0.00%> (ø)
...ices/fas/routing_slip_status_transition_service.py 100.00% <0.00%> (ø)
pay-api/src/pay_api/resources/invoice.py 92.17% <0.00%> (ø)
...api/src/pay_api/models/disbursement_status_code.py 100.00% <0.00%> (ø)
pay-api/src/pay_api/models/distribution_code.py 98.66% <0.00%> (ø)
pay-api/src/pay_api/models/invoice_status_code.py 100.00% <0.00%> (ø)
pay-api/src/pay_api/models/statement_recipients.py 96.55% <0.00%> (ø)
... and 118 more

@seeker25 seeker25 merged commit b4f179a into bcgov:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants