Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oracle stuff to dockerfile #1050

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

kialj876
Copy link
Collaborator

Signed-off-by: Kial Jinnah kialjinnah@gmail.com

Issue #:
bcgov/entity#14381

Description of changes:
needed for oracle connection

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@kialj876 kialj876 added the bug Something isn't working label Dec 12, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #1050 (b197b36) into main (1018d62) will increase coverage by 0.10%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
+ Coverage   79.21%   79.31%   +0.10%     
==========================================
  Files          20       21       +1     
  Lines        1419     1426       +7     
==========================================
+ Hits         1124     1131       +7     
  Misses        295      295              
Flag Coverage Δ
paymentjobs 79.31% <88.23%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jobs/payment-jobs/tasks/cfs_create_invoice_task.py 72.68% <ø> (ø)
jobs/payment-jobs/tasks/routing_slip_task.py 90.53% <87.50%> (+0.34%) ⬆️
jobs/payment-jobs/tasks/ejv_payment_task.py 96.46% <100.00%> (ø)
jobs/payment-jobs/tasks/__init__.py 100.00% <0.00%> (ø)

@kialj876 kialj876 merged commit 147ed28 into bcgov:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants