Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put in max length for folio number, filing identifier. #1051

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

seeker25
Copy link
Collaborator

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #1051 (25175b9) into main (b197b36) will increase coverage by 12.52%.
The diff coverage is 92.30%.

@@             Coverage Diff             @@
##             main    #1051       +/-   ##
===========================================
+ Coverage   79.31%   91.84%   +12.52%     
===========================================
  Files          21      148      +127     
  Lines        1426     9659     +8233     
===========================================
+ Hits         1131     8871     +7740     
- Misses        295      788      +493     
Flag Coverage Δ
payapi 94.01% <84.21%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ices/fas/routing_slip_status_transition_service.py 100.00% <ø> (ø)
...y-api/src/pay_api/services/internal_pay_service.py 90.00% <50.00%> (ø)
pay-api/src/pay_api/services/fas/routing_slip.py 76.42% <84.61%> (ø)
jobs/payment-jobs/tasks/routing_slip_task.py 90.53% <96.96%> (ø)
pay-api/src/pay_api/utils/enums.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/utils/errors.py 98.57% <100.00%> (ø)
..._api/resources/account_statements_notifications.py 58.69% <0.00%> (ø)
pay-api/src/pay_api/services/fas/__init__.py 100.00% <0.00%> (ø)
pay-api/src/pay_api/models/base_model.py 100.00% <0.00%> (ø)
... and 124 more

@seeker25 seeker25 added the bug Something isn't working label Dec 13, 2022
@seeker25 seeker25 merged commit 3d6ec85 into bcgov:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants