14618 - PAY-API changes for routing slip corrections - Part 1 #1063

seeker25 · 2023-01-04T15:50:17Z

Description of changes:
PAY-API changes for routing slip corrections

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

codecov · 2023-01-04T15:57:53Z

Codecov Report

Merging #1063 (ce34e37) into main (b197b36) will increase coverage by 12.21%.
The diff coverage is 86.25%.

@@             Coverage Diff             @@
##             main    #1063       +/-   ##
===========================================
+ Coverage   79.31%   91.53%   +12.21%     
===========================================
  Files          21      162      +141     
  Lines        1426    10626     +9200     
===========================================
+ Hits         1131     9726     +8595     
- Misses        295      900      +605

Flag	Coverage Δ
eventlistenerqueue	`81.63% <ø> (?)`
payadmin	`∅ <ø> (?)`
payapi	`93.87% <86.73%> (?)`
paymentjobs	`78.92% <84.84%> (-0.39%)`	⬇️
paymentreconciliationsqueue	`91.32% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pay-api/src/pay_api/services/__init__.py	`100.00% <ø> (ø)`
...ices/fas/routing_slip_status_transition_service.py	`100.00% <ø> (ø)`
pay-api/src/pay_api/models/routing_slip.py	`91.79% <14.28%> (ø)`
...y-api/src/pay_api/services/internal_pay_service.py	`90.00% <50.00%> (ø)`
pay-api/src/pay_api/services/flags.py	`77.96% <76.92%> (ø)`
pay-api/src/pay_api/services/cfs_service.py	`69.93% <80.00%> (ø)`
jobs/payment-jobs/tasks/routing_slip_task.py	`88.88% <84.84%> (-1.65%)`	⬇️
pay-api/src/pay_api/services/fas/routing_slip.py	`78.83% <95.34%> (ø)`
pay-api/src/pay_api/__init__.py	`89.65% <100.00%> (ø)`
pay-api/src/pay_api/models/db.py	`100.00% <100.00%> (ø)`
... and 151 more