Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15161 - Add in change for invoice.disbursment_date #1083

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Jan 30, 2023

Issue #:
bcgov/entity#15161

Description of changes:
Add in disbursement_date, that way we can easily indicate to our partners when the money has been disbursed - without having to look at updated_on or guessing by looking at the receipts.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@seeker25 seeker25 added the enhancement New feature or request label Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #1083 (b23841f) into main (b62f3a9) will increase coverage by 0.00%.
The diff coverage is 88.67%.

@@           Coverage Diff           @@
##             main    #1083   +/-   ##
=======================================
  Coverage   91.49%   91.50%           
=======================================
  Files         162      162           
  Lines       10623    10645   +22     
=======================================
+ Hits         9720     9741   +21     
- Misses        903      904    +1     
Flag Coverage Δ
eventlistenerqueue 81.63% <ø> (ø)
payadmin ∅ <ø> (∅)
payapi 93.83% <100.00%> (ø)
paymentjobs 79.15% <86.95%> (+0.23%) ⬆️
paymentreconciliationsqueue 91.33% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ices/fas/routing_slip_status_transition_service.py 100.00% <ø> (ø)
...y-api/src/pay_api/services/internal_pay_service.py 90.00% <ø> (ø)
jobs/payment-jobs/tasks/routing_slip_task.py 89.52% <86.95%> (+0.63%) ⬆️
pay-api/src/pay_api/models/invoice.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/services/fas/routing_slip.py 78.76% <100.00%> (-0.08%) ⬇️
...iations/src/reconciliations/cgi_reconciliations.py 92.27% <100.00%> (+0.03%) ⬆️

@seeker25 seeker25 merged commit 86b3e5f into bcgov:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants