Add try except for create_cfs_account. That way if it fails it doesn'… #1084

seeker25 · 2023-01-31T23:20:04Z

…t back up the other accounts.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

…t back up the other accounts.

codecov · 2023-01-31T23:27:24Z

Codecov Report

Merging #1084 (f80f55a) into main (b62f3a9) will decrease coverage by 0.02%.
The diff coverage is 83.87%.

@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
- Coverage   91.49%   91.48%   -0.02%     
==========================================
  Files         162      153       -9     
  Lines       10623     9865     -758     
==========================================
- Hits         9720     9025     -695     
+ Misses        903      840      -63

Flag	Coverage Δ
payadmin	`?`
payapi	`93.83% <100.00%> (ø)`
paymentjobs	`78.95% <81.81%> (+0.03%)`	⬆️
paymentreconciliationsqueue	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ices/fas/routing_slip_status_transition_service.py	`100.00% <ø> (ø)`
...y-api/src/pay_api/services/internal_pay_service.py	`90.00% <ø> (ø)`
jobs/payment-jobs/tasks/cfs_create_account_task.py	`90.24% <55.55%> (-4.57%)`	⬇️
jobs/payment-jobs/tasks/routing_slip_task.py	`89.52% <86.95%> (+0.63%)`	⬆️
pay-api/src/pay_api/models/invoice.py	`100.00% <100.00%> (ø)`
pay-api/src/pay_api/services/fas/routing_slip.py	`78.76% <100.00%> (-0.08%)`	⬇️
pay-api/src/pay_api/version.py	`100.00% <100.00%> (ø)`
...iations/src/reconciliations/cgi_reconciliations.py
...ons/src/reconciliations/payment_reconciliations.py
...nt-reconciliations/src/reconciliations/__init__.py
... and 7 more