Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15086 - Add in registration in process_event. #1087

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Feb 3, 2023

Issue #:
bcgov/entity#15086

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Verified

This commit was signed with the committer’s verified signature.
rouault Even Rouault
@seeker25 seeker25 added the bug Something isn't working label Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #1087 (ebbd5d1) into main (25f3363) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #1087   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         153      153           
  Lines        9894     9895    +1     
=======================================
+ Hits         9056     9057    +1     
  Misses        838      838           
Flag Coverage Δ
eventlistenerqueue 81.81% <66.66%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ces/events-listener/src/events_listener/version.py 0.00% <0.00%> (ø)
...ices/events-listener/src/events_listener/worker.py 92.30% <100.00%> (+0.20%) ⬆️

@seeker25 seeker25 marked this pull request as ready for review February 3, 2023 20:15

Verified

This commit was signed with the committer’s verified signature.
rouault Even Rouault
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@seeker25 seeker25 merged commit 9b1ef00 into main Feb 6, 2023
@seeker25 seeker25 deleted the fix_identifier_for_registration branch March 6, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants