Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invoice count #1099

Merged
merged 4 commits into from
Feb 9, 2023
Merged

Fix invoice count #1099

merged 4 commits into from
Feb 9, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Feb 9, 2023

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 added the bug Something isn't working label Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #1099 (34a5cfc) into main (25f3363) will decrease coverage by 0.01%.
The diff coverage is 88.77%.

❗ Current head 34a5cfc differs from pull request most recent head 9aafb87. Consider uploading reports for the commit 9aafb87 to get more accurate results

@@            Coverage Diff             @@
##             main    #1099      +/-   ##
==========================================
- Coverage   91.53%   91.52%   -0.01%     
==========================================
  Files         153      162       +9     
  Lines        9894    10719     +825     
==========================================
+ Hits         9056     9811     +755     
- Misses        838      908      +70     
Flag Coverage Δ
eventlistenerqueue 81.81% <66.66%> (+0.18%) ⬆️
paymentreconciliationsqueue 91.31% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jobs/payment-jobs/tasks/routing_slip_task.py 89.52% <0.00%> (ø)
...ices/fas/routing_slip_status_transition_service.py 100.00% <ø> (ø)
pay-api/src/pay_api/services/payment_service.py 97.93% <ø> (ø)
...ces/events-listener/src/events_listener/version.py 0.00% <0.00%> (ø)
...ment-reconciliations/src/reconciliations/config.py 96.38% <ø> (ø)
...ons/src/reconciliations/payment_reconciliations.py 91.73% <0.00%> (ø)
...ment-reconciliations/src/reconciliations/worker.py 86.84% <0.00%> (ø)
pay-api/src/pay_api/services/cfs_service.py 69.93% <50.00%> (ø)
pay-api/src/pay_api/models/payment.py 95.52% <94.02%> (-0.24%) ⬇️
pay-api/src/pay_api/exceptions/__init__.py 100.00% <100.00%> (ø)
... and 19 more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 merged commit 16366d0 into bcgov:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants