Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use decimal instead of float. #1118

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Use decimal instead of float. #1118

merged 2 commits into from
Feb 21, 2023

Conversation

seeker25
Copy link
Collaborator

Fixes error:

unsupported operand type(s) for -: 'decimal.Decimal' and 'float' https://registries.sentry.io/issues/3947202203/?end=2023-02-21T10%3A23%3A06&project=1762954&query=is%3Aunresolved+is%3Afor_review+assigned_or_suggested%3A%5Bme%2C+none%5D&referrer=issue-stream&sort=inbox&start=2022-11-23T10%3A23%3A06&utc=true

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 added the bug Something isn't working label Feb 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #1118 (c7fc634) into main (28ff797) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
- Coverage   91.54%   91.52%   -0.02%     
==========================================
  Files         153      162       +9     
  Lines        9842    10625     +783     
==========================================
+ Hits         9010     9725     +715     
- Misses        832      900      +68     
Flag Coverage Δ
paymentreconciliationsqueue 91.32% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pay-api/src/pay_api/resources/account.py 93.40% <ø> (-0.04%) ⬇️
...ons/src/reconciliations/payment_reconciliations.py 91.75% <100.00%> (ø)
...ment-reconciliations/src/reconciliations/config.py 96.38% <0.00%> (ø)
...ent-reconciliations/src/reconciliations/version.py 0.00% <0.00%> (ø)
...iations/src/reconciliations/cgi_reconciliations.py 92.23% <0.00%> (ø)
...ment-reconciliations/src/reconciliations/worker.py 86.84% <0.00%> (ø)
...yment-reconciliations/src/reconciliations/enums.py 100.00% <0.00%> (ø)
...nt-reconciliations/src/reconciliations/__init__.py 100.00% <0.00%> (ø)
...yment-reconciliations/src/reconciliations/minio.py 100.00% <0.00%> (ø)
... and 1 more

@seeker25 seeker25 merged commit 786a15c into main Feb 21, 2023
@seeker25 seeker25 deleted the payment_reconciliation_fix branch March 6, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants