14847 - AP non-gov disbursement for BCA. #1122
Conversation
|
I've submitted a feedback file for BCA on TEST using oc tag for |
Codecov Report
@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
+ Coverage 91.54% 91.57% +0.02%
==========================================
Files 153 162 +9
Lines 9842 10868 +1026
==========================================
+ Hits 9010 9952 +942
- Misses 832 916 +84
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ce.created to now(), we'll change this to the payment_date ideally later.
|
Kudos, SonarCloud Quality Gate passed!
|
| return | ||
|
|
||
| # 250 MAX is all the transactions the feeder can take per batch. | ||
| for invoices in batched(total_invoices, 250): |
| ap_line = APLine.from_invoice_and_line_item(inv, line_item, line_number + 1, bca_distribution) | ||
| ap_content = f'{ap_content}{cls.get_ap_invoice_line(ap_line)}' | ||
| line_number += 1 | ||
| control_total += line_number |
There was a problem hiding this comment.
so control_total is 1 + the number of lineItems? Is that correct or should it be == number of lineItems?
There was a problem hiding this comment.
control_total gets incremented when an AP line is created, I'm just adding the number of payment_line_items to the control_total because we need a control line each time a payment line item is added.
Issue #:
bcgov/entity#14847
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).