Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15257- Fix for exception not coming back correctly. #1134

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Mar 1, 2023

Issue #:
bcgov/entity#15257

Description of changes:
Would return internal error 500, not the bad request error correctly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@seeker25 seeker25 added the bug Something isn't working label Mar 1, 2023
@seeker25 seeker25 temporarily deployed to dev March 1, 2023 20:46 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #1134 (697faff) into main (28ff797) will increase coverage by 0.10%.
The diff coverage is 90.66%.

@@            Coverage Diff             @@
##             main    #1134      +/-   ##
==========================================
+ Coverage   91.54%   91.64%   +0.10%     
==========================================
  Files         153      154       +1     
  Lines        9842    10165     +323     
==========================================
+ Hits         9010     9316     +306     
- Misses        832      849      +17     
Flag Coverage Δ
paymentjobs 80.38% <91.66%> (+1.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jobs/payment-jobs/tasks/routing_slip_task.py 89.09% <0.00%> (-0.43%) ⬇️
pay-api/src/pay_api/services/bcol_service.py 84.44% <9.09%> (-3.80%) ⬇️
jobs/payment-jobs/tasks/cfs_create_invoice_task.py 72.44% <50.00%> (-0.24%) ⬇️
pay-api/src/pay_api/resources/account.py 92.47% <80.00%> (-0.97%) ⬇️
jobs/payment-jobs/tasks/statement_task.py 84.00% <81.08%> (+13.03%) ⬆️
pay-api/src/pay_api/models/payment.py 95.85% <82.35%> (-0.42%) ⬇️
jobs/payment-jobs/tasks/common/cgi_ap.py 88.69% <88.67%> (-2.10%) ⬇️
pay-api/src/pay_api/services/invoice.py 96.79% <90.90%> (-0.23%) ⬇️
jobs/payment-jobs/tasks/ap_task.py 96.03% <96.03%> (ø)
...ayment-jobs/tasks/bcol_refund_confirmation_task.py 73.58% <100.00%> (+1.03%) ⬆️
... and 25 more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 merged commit c13aa15 into bcgov:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants