Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15467 - Statement enhancements, remove duplicates - fix the sort order in pay as well. #1135

Merged
merged 13 commits into from
Mar 3, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Mar 3, 2023

https://www.github.com/bcgov/issues/5467

Description of changes:
This gets rid of duplicate statements, without needing to have a query to remove duplicates.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@seeker25 seeker25 added bug Something isn't working enhancement New feature or request labels Mar 3, 2023
@seeker25 seeker25 changed the title Statement changes, remove duplicates. Statement enhancements, remove duplicates - fix the sort order in pay as well. Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1135 (fde3c70) into main (28ff797) will increase coverage by 0.03%.
The diff coverage is 90.86%.

@@            Coverage Diff             @@
##             main    #1135      +/-   ##
==========================================
+ Coverage   91.54%   91.57%   +0.03%     
==========================================
  Files         153      163      +10     
  Lines        9842    11006    +1164     
==========================================
+ Hits         9010    10079    +1069     
- Misses        832      927      +95     
Flag Coverage Δ
eventlistenerqueue 81.81% <ø> (-0.48%) ⬇️
payadmin ∅ <ø> (?)
payapi 93.88% <88.96%> (-0.03%) ⬇️
paymentjobs 80.04% <90.04%> (+1.09%) ⬆️
paymentreconciliationsqueue 91.71% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jobs/payment-jobs/tasks/routing_slip_task.py 89.09% <0.00%> (-0.43%) ⬇️
pay-api/src/pay_api/services/bcol_service.py 84.44% <9.09%> (-3.80%) ⬇️
jobs/payment-jobs/tasks/cfs_create_invoice_task.py 72.44% <50.00%> (-0.24%) ⬇️
jobs/payment-jobs/tasks/statement_task.py 77.27% <76.00%> (+6.30%) ⬆️
pay-api/src/pay_api/resources/account.py 92.47% <80.00%> (-0.97%) ⬇️
pay-api/src/pay_api/models/payment.py 95.85% <82.35%> (-0.42%) ⬇️
pay-api/src/pay_api/utils/util.py 91.53% <83.33%> (ø)
jobs/payment-jobs/tasks/common/cgi_ap.py 88.69% <88.67%> (-2.10%) ⬇️
pay-api/src/pay_api/services/invoice.py 96.79% <90.90%> (-0.23%) ⬇️
jobs/payment-jobs/tasks/ap_task.py 96.03% <96.03%> (ø)
... and 40 more

@seeker25 seeker25 temporarily deployed to dev March 3, 2023 04:56 — with GitHub Actions Inactive
@seeker25 seeker25 force-pushed the statement_job_enhancement branch from 85ead2f to f0f7b58 Compare March 3, 2023 05:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25
Copy link
Collaborator Author

seeker25 commented Mar 3, 2023

Seems to be working on DEV:

image

Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 👍

@seeker25 seeker25 changed the title Statement enhancements, remove duplicates - fix the sort order in pay as well. 15467 - Statement enhancements, remove duplicates - fix the sort order in pay as well. Mar 3, 2023
@seeker25
Copy link
Collaborator Author

seeker25 commented Mar 3, 2023

Thank you Kial

@seeker25 seeker25 merged commit 3a02015 into bcgov:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants