Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in data for no fee, add in details field for credits, update developer notes. #1143

Merged
merged 5 commits into from
Mar 16, 2023

Conversation

seeker25
Copy link
Collaborator

Add in a details field in credits - that way we can capture information regarding the credits.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Add in a details field in credits - that way we can capture information regarding the credits.
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #1143 (53d64d0) into main (28ff797) will increase coverage by 0.06%.
The diff coverage is 91.73%.

@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
+ Coverage   91.54%   91.61%   +0.06%     
==========================================
  Files         153      163      +10     
  Lines        9842    11053    +1211     
==========================================
+ Hits         9010    10126    +1116     
- Misses        832      927      +95     
Flag Coverage Δ
eventlistenerqueue 81.81% <ø> (-0.48%) ⬇️
payadmin ∅ <ø> (?)
payapi 93.91% <91.37%> (+<0.01%) ⬆️
paymentjobs 80.06% <90.08%> (+1.10%) ⬆️
paymentreconciliationsqueue 91.74% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jobs/payment-jobs/tasks/routing_slip_task.py 89.09% <0.00%> (-0.43%) ⬇️
pay-api/src/pay_api/services/bcol_service.py 84.44% <9.09%> (-3.80%) ⬇️
jobs/payment-jobs/tasks/cfs_create_invoice_task.py 72.44% <50.00%> (-0.24%) ⬇️
jobs/payment-jobs/tasks/statement_task.py 77.52% <76.47%> (+6.56%) ⬆️
pay-api/src/pay_api/resources/account.py 92.47% <80.00%> (-0.97%) ⬇️
pay-api/src/pay_api/models/payment.py 95.87% <83.33%> (-0.40%) ⬇️
pay-api/src/pay_api/utils/util.py 91.53% <83.33%> (ø)
jobs/payment-jobs/tasks/common/cgi_ap.py 88.69% <88.67%> (-2.10%) ⬇️
pay-api/src/pay_api/services/invoice.py 96.79% <90.90%> (-0.23%) ⬇️
jobs/payment-jobs/tasks/ap_task.py 96.03% <96.03%> (ø)
... and 53 more

... and 15 files with indirect coverage changes

@seeker25 seeker25 added the enhancement New feature or request label Mar 16, 2023
@seeker25 seeker25 changed the title Add in TRF04 ($0.00), we've manually added these into DEV/TEST for now. Add in data for no fee, add in details field for credits, update developer notes. Mar 16, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 merged commit 1bc080a into bcgov:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants