Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAY-JOBS - Use the latest version of pay-api. #1154

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Mar 27, 2023

Ran make build-reqs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-advanced-security
Copy link
Contributor

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #1154 (f538bfb) into main (28ff797) will decrease coverage by 11.33%.
The diff coverage is 90.40%.

@@             Coverage Diff             @@
##             main    #1154       +/-   ##
===========================================
- Coverage   91.54%   80.22%   -11.33%     
===========================================
  Files         153       21      -132     
  Lines        9842     1623     -8219     
===========================================
- Hits         9010     1302     -7708     
+ Misses        832      321      -511     
Flag Coverage Δ
eventlistenerqueue ?
payapi ?
paymentjobs 80.22% <90.40%> (+1.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jobs/payment-jobs/tasks/routing_slip_task.py 89.09% <0.00%> (-0.43%) ⬇️
jobs/payment-jobs/tasks/cfs_create_invoice_task.py 72.44% <50.00%> (-0.24%) ⬇️
jobs/payment-jobs/tasks/statement_task.py 80.43% <79.66%> (+9.46%) ⬆️
jobs/payment-jobs/tasks/common/cgi_ap.py 88.69% <88.67%> (-2.10%) ⬇️
jobs/payment-jobs/tasks/ap_task.py 96.03% <96.03%> (ø)
...ayment-jobs/tasks/bcol_refund_confirmation_task.py 73.58% <100.00%> (+1.03%) ⬆️
jobs/payment-jobs/tasks/common/dataclasses.py 100.00% <100.00%> (ø)
...ent-jobs/tasks/direct_pay_automated_refund_task.py 86.04% <100.00%> (-0.48%) ⬇️
jobs/payment-jobs/tasks/distribution_task.py 97.75% <100.00%> (+0.05%) ⬆️
...ayment-jobs/tasks/ejv_partner_distribution_task.py 99.13% <100.00%> (ø)

... and 132 files with indirect coverage changes

@seeker25 seeker25 temporarily deployed to dev March 27, 2023 21:07 — with GitHub Actions Inactive
@seeker25 seeker25 merged commit 858402b into bcgov:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants