16408 - pay-api: Exception on /api/v1/accounts/9789/statements/2047079 #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
+ Coverage 91.54% 91.63% +0.08%
==========================================
Files 153 163 +10
Lines 9842 11064 +1222
==========================================
+ Hits 9010 10138 +1128
- Misses 832 926 +94
Flags with carried forward coverage won't be shown. Click here to find out more.
|
seeker25
reviewed
May 19, 2023
| @@ -257,6 +257,8 @@ def search_purchase_history(cls, # noqa:E501; pylint:disable=too-many-arguments | |||
| if count > 60000: | |||
| raise BusinessException(Error.PAYMENT_SEARCH_TOO_MANY_RECORDS) | |||
| result = query.all() | |||
| if result is None: | |||
There was a problem hiding this comment.
Don't need this, query.all() always returns an array
seeker25
reviewed
May 19, 2023
| @@ -103,8 +103,9 @@ def create_invoice(cls, payment_request: Tuple[Dict[str, Any]], authorization: T | |||
| invoice.business_identifier = business_identifier | |||
| invoice.payment_method_code = pay_service.get_payment_method_code() | |||
| invoice.corp_type_code = corp_type | |||
| details = payment_request.get('details', []) | |||
There was a problem hiding this comment.
My fault here, didn't realize payment_request.get('details',[]) returns None, figured it would return a value for details or []
seeker25
approved these changes
May 19, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#16408
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).