18468 - EFT Credits / Model updates

[ochiu]

Issue #:
bcgov/entity#18468

Description of changes:

• Remove old EFT and WIRE cfs invoice creation job calls
• Add eft_credits table to track overpayment
• Add eft_short_names versioning table
• Implementation usage of eft_credits similar to existing cfs credits
• Refactor to separate CFS and EFT credits + feature flag
• EFT Credit test for applying credits fully, partially and remaining credit balance

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

[codecov]

Codecov Report

Merging #1315 (7312047) into main (79924ce) will increase coverage by 0.57%.
Report is 37 commits behind head on main.
The diff coverage is 96.02%.

@@            Coverage Diff             @@
##             main    #1315      +/-   ##
==========================================
+ Coverage   91.45%   92.02%   +0.57%     
==========================================
  Files         186      180       -6     
  Lines       11319    11491     +172     
==========================================
+ Hits        10352    10575     +223     
+ Misses        967      916      -51     

Flag	Coverage Δ
bcolapi	?
eventlistenerqueue	82.00% <100.00%> (+0.18%)	⬆️
payadmin	∅ <ø> (?)
paymentjobs	82.97% <93.54%> (+2.75%)	⬆️
paymentreconciliationsqueue	92.71% <97.50%> (+1.26%)	⬆️
reportapi	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
jobs/payment-jobs/tasks/cfs_create_invoice_task.py	71.03% <ø> (-1.42%)	⬇️
jobs/payment-jobs/tasks/common/dataclasses.py	100.00% <100.00%> (ø)
jobs/payment-jobs/tasks/common/enums.py	100.00% <ø> (ø)
...ent-jobs/tasks/direct_pay_automated_refund_task.py	85.71% <100.00%> (-0.34%)	⬇️
jobs/payment-jobs/tasks/distribution_task.py	97.75% <100.00%> (ø)
.../payment-jobs/tasks/statement_notification_task.py	79.74% <100.00%> (+47.92%)	⬆️
pay-api/src/pay_api/models/__init__.py	100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_credit.py	100.00% <100.00%> (ø)
pay-api/src/pay_api/models/eft_file.py	100.00% <100.00%> (ø)
...-api/src/pay_api/models/eft_process_status_code.py	100.00% <100.00%> (ø)
... and 31 more

... and 23 files with indirect coverage changes

[seeker25]

I've remade the issue as a ticket instead of the epic, I've repointed the title and description at it.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication