Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19331-EFT-Shortname-search #1393

Merged
merged 1 commit into from
Jan 31, 2024
Merged

19331-EFT-Shortname-search #1393

merged 1 commit into from
Jan 31, 2024

Conversation

ochiu
Copy link
Collaborator

@ochiu ochiu commented Jan 31, 2024

Issue #:
bcgov/entity#19331

Description of changes:

  • add account name and branch to support Linked short name search

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

- add account name and branch
@ochiu ochiu requested review from seeker25 and Jxio as code owners January 31, 2024 22:16
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 117 lines in your changes are missing coverage. Please review.

Comparison is base (79924ce) 91.45% compared to head (c410902) 92.13%.
Report is 90 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1393      +/-   ##
==========================================
+ Coverage   91.45%   92.13%   +0.68%     
==========================================
  Files         186      192       +6     
  Lines       11319    12705    +1386     
==========================================
+ Hits        10352    11706    +1354     
- Misses        967      999      +32     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue 82.00% <100.00%> (+0.18%) ⬆️
payapi 93.71% <92.53%> (-0.02%) ⬇️
paymentjobs 84.45% <96.36%> (+4.23%) ⬆️
paymentreconciliationsqueue 92.39% <93.93%> (+0.95%) ⬆️
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
jobs/payment-jobs/tasks/common/dataclasses.py 100.00% <100.00%> (ø)
jobs/payment-jobs/tasks/common/enums.py 100.00% <ø> (ø)
jobs/payment-jobs/tasks/distribution_task.py 97.70% <100.00%> (-0.06%) ⬇️
...ayment-jobs/tasks/ejv_partner_distribution_task.py 99.17% <100.00%> (+0.03%) ⬆️
jobs/payment-jobs/tasks/ejv_payment_task.py 96.61% <100.00%> (+0.14%) ⬆️
.../payment-jobs/tasks/statement_notification_task.py 79.74% <100.00%> (+47.92%) ⬆️
jobs/payment-jobs/tasks/statement_task.py 91.39% <100.00%> (+10.96%) ⬆️
pay-api/src/pay_api/config.py 99.35% <100.00%> (+<0.01%) ⬆️
pay-api/src/pay_api/models/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/custom_query.py 100.00% <100.00%> (ø)
... and 71 more

... and 23 files with indirect coverage changes

@ochiu ochiu merged commit 4f4abea into bcgov:main Jan 31, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants