Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20454 - PUB/SUB Integration TEST on Python 3.8 #1537

Merged
merged 14 commits into from
May 23, 2024
Merged

Conversation

seeker25
Copy link
Collaborator

bcgov/entity#20454

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 marked this pull request as draft May 21, 2024 19:36
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (79924ce) to head (2b6c66f).
Report is 149 commits behind head on main.

Current head 2b6c66f differs from pull request most recent head 77b473d

Please upload reports for the commit 77b473d to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1537      +/-   ##
==========================================
+ Coverage   91.45%   92.89%   +1.43%     
==========================================
  Files         186      169      -17     
  Lines       11319    11143     -176     
==========================================
- Hits        10352    10351       -1     
+ Misses        967      792     -175     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi 93.15% <100.00%> (-0.59%) ⬇️
paymentjobs ?
paymentreconciliationsqueue 91.02% <100.00%> (-0.42%) ⬇️
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pay-api/src/pay_api/services/payment_account.py 95.84% <100.00%> (-1.57%) ⬇️
pay-queue/src/pay_queue/__init__.py 82.05% <100.00%> (ø)
pay-queue/src/pay_queue/config.py 93.24% <100.00%> (ø)
pay-queue/src/pay_queue/resources/worker.py 86.11% <100.00%> (ø)
pay-queue/src/pay_queue/services/__init__.py 100.00% <ø> (ø)

... and 79 files with indirect coverage changes

@seeker25 seeker25 marked this pull request as ready for review May 22, 2024 18:10
@seeker25
Copy link
Collaborator Author

Mostly going through payment-jobs now, making sure all that pub stuff is working.

Copy link
Collaborator

@ochiu ochiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the minor linting error

@seeker25 seeker25 changed the title 20454 - PUB/SUB Integration TEST on python 3.8 20454 - PUB/SUB Integration TEST on Python 3.8 May 23, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@seeker25 seeker25 merged commit 097541d into bcgov:main May 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants