Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20088 - Unlock associated accounts when paid with exact amount #1561

Merged
merged 8 commits into from
Jun 10, 2024

Conversation

rodrigo-barraza
Copy link
Collaborator

Issue #:
bcgov/entity#20088

Description of changes:
Unlocking overdue BCROS account when paid with exact amount

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 changed the title 20088- Unlock associated accounts when paid with exact amount 20088 - Unlock associated accounts when paid with exact amount Jun 7, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.30%. Comparing base (79924ce) to head (66dc406).
Report is 172 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
+ Coverage   91.45%   93.30%   +1.84%     
==========================================
  Files         186      146      -40     
  Lines       11319     9777    -1542     
==========================================
- Hits        10352     9122    -1230     
+ Misses        967      655     -312     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue ?
payapi 93.30% <100.00%> (-0.44%) ⬇️
paymentjobs ?
paymentreconciliationsqueue ?
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pay-api/src/pay_api/services/__init__.py 100.00% <100.00%> (ø)

... and 194 files with indirect coverage changes

@rodrigo-barraza rodrigo-barraza marked this pull request as ready for review June 10, 2024 15:29
@seeker25 seeker25 merged commit ca964bc into main Jun 10, 2024
10 checks passed
@rodrigo-barraza rodrigo-barraza deleted the feature/20088 branch September 4, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants