Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22063 - Fix receipt method for EFT #1596

Merged
merged 1 commit into from
Jul 2, 2024
Merged

22063 - Fix receipt method for EFT #1596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jobs/payment-jobs/tasks/cfs_create_account_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from pay_api.models import PaymentAccount as PaymentAccountModel
from pay_api.services.cfs_service import CFSService
from pay_api.services.oauth_service import OAuthService
from pay_api.utils.constants import RECEIPT_METHOD_EFT_MONTHLY, RECEIPT_METHOD_PAD_DAILY
from pay_api.utils.constants import CFS_RCPT_EFT_WIRE, RECEIPT_METHOD_PAD_DAILY
from pay_api.utils.enums import AuthHeaderType, CfsAccountStatus, ContentType, PaymentMethod
from sbc_common_components.utils.enums import QueueMessageTypes
from sentry_sdk import capture_message
Expand Down Expand Up @@ -99,7 +99,7 @@ def _create_cfs_account(cls, pending_account: CfsAccountModel, pay_account: Paym
if pay_account.payment_method == PaymentMethod.EFT.value:
cfs_account_details = CFSService.create_cfs_account(identifier=pay_account.auth_account_id,
contact_info=contact_info,
receipt_method=RECEIPT_METHOD_EFT_MONTHLY)
receipt_method=CFS_RCPT_EFT_WIRE)
elif pending_account.cfs_account and pending_account.cfs_party and pending_account.cfs_site:
# This means, PAD account details have changed. So update banking details for this CFS account
bank_details = CFSService.update_bank_details(name=pay_account.auth_account_id,
Expand Down
1 change: 0 additions & 1 deletion pay-api/src/pay_api/utils/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
DEFAULT_CURRENCY = 'CAD'
RECEIPT_METHOD_PAD_DAILY = 'BCR-PAD Daily'
RECEIPT_METHOD_PAD_STOP = 'BCR-PAD Stop'
RECEIPT_METHOD_EFT_MONTHLY = 'BCR-EFT MONTHLY'

CFS_BATCH_SOURCE = 'BC REG MANUAL_OTHER'
CFS_CM_BATCH_SOURCE = 'MANUAL-OTHER'
Expand Down
Loading