20596 - Rework EFT receipt and apply/reverse invoices job #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeker25
commented
Jul 17, 2024
seeker25
commented
Jul 17, 2024
seeker25
commented
Jul 17, 2024
seeker25
commented
Jul 17, 2024
seeker25
commented
Jul 17, 2024
seeker25
commented
Jul 17, 2024
|
@ochiu take a look it this if you have a sec, tests aren't done.. still needs some more |
seeker25
commented
Jul 17, 2024
seeker25
commented
Jul 17, 2024
seeker25
commented
Jul 17, 2024
seeker25
changed the title
seeker25
requested review from
Jxio,
ochiu,
rodrigo-barraza and
avni-work
as code owners
seeker25
commented
Jul 17, 2024
|
|
||
| __tablename__ = 'eft_gl_transfers' | ||
| # TODO requires migration, handle in disbursement ticket | ||
| class PartnerDisbursements(BaseModel): # pylint: disable=too-many-instance-attributes |
There was a problem hiding this comment.
Not used, will use next ticket probably
ochiu
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#20596
Description of changes:
Make EFT job run off of other source of truth
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).