20087 - Statement locking and notification #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeker25
commented
Jul 31, 2024
seeker25
commented
Jul 31, 2024
seeker25
commented
Jul 31, 2024
|
Just taking this for a test drive now. |
seeker25
commented
Aug 1, 2024
| # Correct for daylight savings. | ||
| hours = target_datetime.astimezone(pytz.timezone('America/Vancouver')).utcoffset().total_seconds() / 60 / 60 | ||
| target_date = target_datetime.replace(tzinfo=timezone.utc) + relativedelta(hours=-hours) | ||
| return target_date.replace(tzinfo=None) |
There was a problem hiding this comment.
If i didn't do this, I would see weird behavour, would sometimes remove the hours.. but in the model unit test the hours* persists. tzinfo=None seems to make it always show the hours
seeker25
commented
Aug 1, 2024
| @@ -21,7 +21,7 @@ | |||
| from .db import db | |||
|
|
|||
|
|
|||
| class NonSufficientFundsModel(BaseModel): # pylint: disable=too-many-instance-attributes | |||
| class NonSufficientFunds(BaseModel): # pylint: disable=too-many-instance-attributes | |||
There was a problem hiding this comment.
renamed to make this consistent
seeker25
commented
Aug 1, 2024
| @@ -51,6 +51,11 @@ class NonSufficientFundsModel(BaseModel): # pylint: disable=too-many-instance-a | |||
| invoice_id = db.Column(db.Integer, ForeignKey('invoices.id'), nullable=False) | |||
| invoice_number = db.Column(db.String(50), nullable=False, index=True, comment='CFS Invoice number') | |||
|
|
|||
| @classmethod | |||
| def find_by_invoice_id(cls, invoice_id: int): | |||
There was a problem hiding this comment.
small helper function only works on NonSufficientFunds (no complex joins to other entity types, should be fine)
This reverts commit 68f320d.
seeker25
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#20087
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).