24990 & 24991 - Use Google buckets instead of SFTP #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeker25
changed the title
seeker25
commented
Dec 20, 2024
seeker25
commented
Dec 20, 2024
seeker25
requested review from
Jxio,
ochiu and
rodrigo-barraza
as code owners
seeker25
commented
Dec 20, 2024
| from google.cloud import storage | ||
|
|
||
|
|
||
| def upload_to_bucket(local_file_path: str, trg_file_path: str): |
There was a problem hiding this comment.
Will move this to pay-api when the time is right and we get rid of Minio
Jxio
reviewed
Dec 20, 2024
Jxio
approved these changes
Dec 20, 2024
|
Need to add in some secrets before merging |
|
Added the secrets, just need to try this in TEST after merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#24990
bcgov/entity#24991
Description of changes:
Fix broken unit tests too
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).