Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for populating receipt_number to payments table for all payment types #740

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

sumesh-aot
Copy link
Contributor

Issue #:
bcgov/entity#7896

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #740 (9bfb83f) into main (ee3123a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #740   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files         158      158           
  Lines        8113     8114    +1     
=======================================
+ Hits         7403     7404    +1     
  Misses        710      710           
Flag Coverage Δ
payapi 92.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pay-api/src/pay_api/services/payment.py 97.01% <100.00%> (ø)
...ay-api/src/pay_api/services/payment_transaction.py 97.38% <100.00%> (+<0.01%) ⬆️

@sumesh-aot sumesh-aot merged commit f8292fc into bcgov:main Aug 6, 2021
@sumesh-aot sumesh-aot deleted the 7896 branch August 6, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants