Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes on reconciliation #774

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Fixes on reconciliation #774

merged 1 commit into from
Sep 16, 2021

Conversation

sumesh-aot
Copy link
Contributor

@sumesh-aot sumesh-aot commented Sep 15, 2021

Issue #:
bcgov/entity#9017

Description of changes:

  • Adding sentry alert if no invoice is found on reconciliation
  • Setting the transaction number in CFS to first invoice number

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@sumesh-aot sumesh-aot added the bug Something isn't working label Sep 15, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #774 (4f53470) into main (0fd85f4) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
+ Coverage   91.52%   91.76%   +0.24%     
==========================================
  Files         158      167       +9     
  Lines        8373     9080     +707     
==========================================
+ Hits         7663     8332     +669     
- Misses        710      748      +38     
Flag Coverage Δ
payapi 93.29% <100.00%> (+0.05%) ⬆️
paymentjobs 75.78% <100.00%> (ø)
paymentreconciliationsqueue 94.15% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jobs/payment-jobs/tasks/cfs_create_invoice_task.py 85.22% <100.00%> (ø)
pay-api/src/pay_api/services/bcol_service.py 88.73% <100.00%> (ø)
...ons/src/reconciliations/payment_reconciliations.py 93.51% <100.00%> (ø)
...y-api/src/pay_api/services/internal_pay_service.py 98.14% <0.00%> (-1.86%) ⬇️
pay-api/src/pay_api/resources/fee_schedule.py 91.66% <0.00%> (-0.65%) ⬇️
pay-api/src/pay_api/models/audit.py 100.00% <0.00%> (ø)
pay-api/src/pay_api/models/base_schema.py 100.00% <0.00%> (ø)
pay-api/src/pay_api/services/fee_schedule.py 99.52% <0.00%> (ø)
...ment-reconciliations/src/reconciliations/config.py 96.20% <0.00%> (ø)
... and 15 more

@sumesh-aot sumesh-aot merged commit fe3aa9e into bcgov:main Sep 16, 2021
@sumesh-aot sumesh-aot deleted the auth_changes branch September 16, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants