Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for allowing a sandbox account to be created by service account #811

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

sumesh-aot
Copy link
Contributor

Issue #:
bcgov/entity#9800

Description of changes:

  • Allow service account with create_sanbox_account role to allow creating sandbox accounts
  • Set the sandbox account status to ACTIVE and set the PAD activation time to now

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@sumesh-aot sumesh-aot added the enhancement New feature or request label Nov 8, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #811 (7028ab0) into main (c1b1002) will increase coverage by 0.00%.
The diff coverage is 93.66%.

@@           Coverage Diff           @@
##             main     #811   +/-   ##
=======================================
  Coverage   91.46%   91.47%           
=======================================
  Files         161      161           
  Lines        8811     8821   +10     
=======================================
+ Hits         8059     8069   +10     
  Misses        752      752           
Flag Coverage Δ
payadmin ?
payapi 93.10% <95.75%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pay-api/src/pay_api/resources/fas/refund.py 96.66% <ø> (ø)
pay-api/src/pay_api/utils/constants.py 100.00% <ø> (ø)
pay-api/src/pay_api/models/routing_slip.py 98.24% <66.66%> (ø)
jobs/payment-jobs/tasks/cfs_create_account_task.py 80.70% <70.96%> (ø)
...y-api/src/pay_api/services/internal_pay_service.py 97.67% <89.47%> (ø)
pay-api/src/pay_api/services/fas/comment.py 92.07% <92.07%> (ø)
jobs/payment-jobs/tasks/ejv_payment_task.py 96.96% <92.85%> (ø)
pay-api/src/pay_api/resources/fas/routing_slip.py 97.04% <97.56%> (ø)
...ay-api/src/pay_api/services/base_payment_system.py 96.00% <97.82%> (ø)
...ayment-jobs/tasks/ejv_partner_distribution_task.py 99.05% <100.00%> (ø)
... and 33 more

@sumesh-aot sumesh-aot marked this pull request as ready for review November 9, 2021 20:24
@sumesh-aot sumesh-aot self-assigned this Nov 9, 2021
@sumesh-aot sumesh-aot merged commit 7c54d5c into bcgov:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants