Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to invoice status for EJV refunds #812

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

sumesh-aot
Copy link
Contributor

Issue #:
https://github.com/bcgov/entity/issues/

Description of changes:

  • Changes to invoice status for EJV refunds

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@sumesh-aot sumesh-aot added the bug Something isn't working label Nov 9, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #812 (742848a) into main (c1b1002) will decrease coverage by 0.04%.
The diff coverage is 92.13%.

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   91.46%   91.41%   -0.05%     
==========================================
  Files         161      161              
  Lines        8811     8818       +7     
==========================================
+ Hits         8059     8061       +2     
- Misses        752      757       +5     
Flag Coverage Δ
payadmin ?
payapi 93.03% <93.85%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pay-api/src/pay_api/resources/fas/refund.py 96.66% <ø> (ø)
pay-api/src/pay_api/utils/constants.py 100.00% <ø> (ø)
pay-api/src/pay_api/services/ejv_pay_service.py 89.58% <28.57%> (-10.42%) ⬇️
pay-api/src/pay_api/models/routing_slip.py 98.24% <66.66%> (ø)
jobs/payment-jobs/tasks/cfs_create_account_task.py 80.70% <70.96%> (ø)
...y-api/src/pay_api/services/internal_pay_service.py 97.67% <89.47%> (ø)
pay-api/src/pay_api/services/fas/comment.py 92.07% <92.07%> (ø)
jobs/payment-jobs/tasks/ejv_payment_task.py 96.96% <92.85%> (ø)
pay-api/src/pay_api/resources/fas/routing_slip.py 97.04% <97.56%> (ø)
...ay-api/src/pay_api/services/base_payment_system.py 96.00% <97.82%> (ø)
... and 36 more

@sumesh-aot sumesh-aot merged commit f7ca9db into bcgov:main Nov 9, 2021
@sumesh-aot sumesh-aot deleted the jv_refund_status branch November 9, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants