Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for marking payment records as complete for sandbox tokens #817

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

sumesh-aot
Copy link
Contributor

Issue #:
bcgov/entity#9801

Description of changes:

  • Changes for marking payment records as complete for sandbox tokens

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@sumesh-aot sumesh-aot added the enhancement New feature or request label Nov 13, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #817 (2e8bd84) into main (7028ab0) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   91.47%   91.42%   -0.06%     
==========================================
  Files         161      161              
  Lines        8821     8858      +37     
==========================================
+ Hits         8069     8098      +29     
- Misses        752      760       +8     
Flag Coverage Δ
payapi 93.03% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ay-api/src/pay_api/services/base_payment_system.py 96.35% <100.00%> (+0.35%) ⬆️
pay-api/src/pay_api/services/bcol_service.py 89.74% <100.00%> (ø)
pay-api/src/pay_api/services/ejv_pay_service.py 85.29% <100.00%> (-14.71%) ⬇️
...y-api/src/pay_api/services/internal_pay_service.py 95.12% <100.00%> (-2.56%) ⬇️
pay-api/src/pay_api/services/pad_service.py 98.38% <100.00%> (+0.17%) ⬆️
pay-api/src/pay_api/utils/enums.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/utils/user_context.py 98.82% <100.00%> (+0.02%) ⬆️
... and 4 more

@sumesh-aot sumesh-aot marked this pull request as ready for review November 15, 2021 15:56
@sumesh-aot sumesh-aot self-assigned this Nov 15, 2021
@sumesh-aot sumesh-aot merged commit 54c9a7b into bcgov:main Nov 15, 2021
@sumesh-aot sumesh-aot deleted the sandbox branch November 15, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants