Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13055 - CAS Settlement error, plus ACK issues #997

Merged
merged 7 commits into from
Oct 4, 2022
Merged

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Oct 3, 2022

Issue #:
bcgov/entity#13055

Description of changes:

  • New cas_settlement table, keeps track of which CSV's were successfully processed (and not processed)
  • New ejv_file.ack_file_ref column, to keep track of ack's, for example saw an ack from July sent over again today.. not really sure why. Some of the queue messages can be sent more than once, so it's necessary to keep track of them
  • Handle multiple failure payments incase CAS sends back multiple edit rejections over multiple days

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #997 (72d7c12) into main (bca253f) will decrease coverage by 0.20%.
The diff coverage is 93.11%.

@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
- Coverage   91.04%   90.83%   -0.21%     
==========================================
  Files         165      149      -16     
  Lines        9576     9576              
==========================================
- Hits         8718     8698      -20     
- Misses        858      878      +20     
Flag Coverage Δ
bcolapi ?
eventlistenerqueue 81.05% <100.00%> (+0.20%) ⬆️
reportapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jobs/payment-jobs/tasks/cfs_bank_name_updater.py 0.00% <0.00%> (ø)
.../payment-jobs/tasks/statement_notification_task.py 31.81% <0.00%> (ø)
pay-api/src/pay_api/models/invoice_reference.py 100.00% <ø> (ø)
pay-api/src/pay_api/models/routing_slip.py 95.96% <0.00%> (-0.91%) ⬇️
pay-api/src/pay_api/services/paybc_service.py 80.00% <ø> (ø)
pay-api/src/pay_api/services/fas/routing_slip.py 75.79% <75.00%> (+0.10%) ⬆️
...ent-jobs/tasks/direct_pay_automated_refund_task.py 86.51% <86.51%> (ø)
jobs/payment-jobs/tasks/ejv_payment_task.py 95.65% <94.11%> (-0.51%) ⬇️
jobs/payment-jobs/tasks/distribution_task.py 97.70% <96.96%> (+60.20%) ⬆️
jobs/payment-jobs/tasks/cfs_create_invoice_task.py 73.25% <100.00%> (+0.31%) ⬆️
... and 68 more

@seeker25 seeker25 added the bug Something isn't working label Oct 3, 2022
@seeker25 seeker25 marked this pull request as ready for review October 3, 2022 21:18
@seeker25 seeker25 requested a review from ritvick as a code owner October 3, 2022 21:18
@seeker25 seeker25 changed the title 13055 - Migration and pay-api changes for payment-reconcilliations 13055 - CAS Settlement error, plus ACK issues Oct 3, 2022
@seeker25 seeker25 temporarily deployed to dev October 3, 2022 21:29 Inactive
@seeker25 seeker25 temporarily deployed to dev October 3, 2022 21:30 Inactive
Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Travis looks good to me. I just skimmed through and looks good for what you told me in RC. Just have those 2 things to update back to bcgov

Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once the reqs are back I think

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seeker25 seeker25 merged commit a36ed35 into bcgov:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants