-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
13055 - CAS Settlement error, plus ACK issues #997
Conversation
Codecov Report
@@ Coverage Diff @@
## main #997 +/- ##
==========================================
- Coverage 91.04% 90.83% -0.21%
==========================================
Files 165 149 -16
Lines 9576 9576
==========================================
- Hits 8718 8698 -20
- Misses 858 878 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Travis looks good to me. I just skimmed through and looks good for what you told me in RC. Just have those 2 things to update back to bcgov
queue_services/payment-reconciliations/requirements/repo-libraries.txt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go once the reqs are back I think
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Issue #:
bcgov/entity#13055
Description of changes:
cas_settlement
table, keeps track of which CSV's were successfully processed (and not processed)ejv_file.ack_file_ref
column, to keep track of ack's, for example saw an ack from July sent over again today.. not really sure why. Some of the queue messages can be sent more than once, so it's necessary to keep track of themBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).