Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Github API to trigger workflow and fetch issues #41

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

tronghieuvuong
Copy link
Contributor

Summary

Use Github API to trigger workflow in this repo https://github.com/bcgov/metrics-report/ pull the metrics for Entity team and display its output issue to frontend. Sample issue that is expected to fetch: bcgov/metrics-report#65

Frontend: Display the raw response fetched from the issue

@tronghieuvuong
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://application-status-dev--pr-41-ojo7tfb1.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://release-notes-dev--pr-41-v7ku8awj.web.app

apps/application-status/composables/getIssues.ts Outdated Show resolved Hide resolved
apps/application-status/package-lock.json Show resolved Hide resolved
ZENHUB_APIKEY
GITHUB_TOKEN
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are you pulling GITHUB_TOKEN from? If you want this variable to be in gcbrun, you will need to add it here:


If you also want it to be loaded in the builds from 1password, you will need to add it here https://github.com/bcgov/sbc-producthub/blob/main/apps/application-status/vaults.env probably something like GITHUB_TOKEN ="op://API/$APP_ENV/github/GITHUB_TOKEN"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I did not have the permission to add the key on GCP or 1password yet, therefore, gcbrun build is currently failing to display, and the same for dev build

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent you direct message about the key value, as I don't know which value you are using

@tronghieuvuong tronghieuvuong self-assigned this Dec 4, 2023
@tronghieuvuong
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://application-status-dev--pr-41-ojo7tfb1.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://release-notes-dev--pr-41-v7ku8awj.web.app

ZENHUB_APIKEY="op://API/$APP_ENV/zenhub/ZENHUB_APIKEY"
GITHUB_TOKEN="op://API/$APP_ENV/zenhub/ZENHUB_APIKEY"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be GITHUB_TOKEN="op://API/$APP_ENV/github/GITHUB_TOKEN""

@tronghieuvuong
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://application-status-dev--pr-41-ojo7tfb1.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://release-notes-dev--pr-41-v7ku8awj.web.app

@tronghieuvuong tronghieuvuong merged commit 0cd1d36 into bcgov:main Dec 4, 2023
6 checks passed
@tronghieuvuong tronghieuvuong deleted the tvuong/githubAPI branch December 4, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants