Migrate GHA deployment workflows to ArgoCD triggering #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
esune
previously approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Looks good, if @WadeBarnes can take a peek and confirm it would be optimal.
I logged an issue (see here) to further deal with updates and management of values files.
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
cleanup, update toipc repo, trigger argo Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
Signed-off-by: Ivan Polchenko <2119240+i5okie@users.noreply.github.com>
WadeBarnes
approved these changes
Jul 19, 2024
esune
approved these changes
Jul 19, 2024
|
@i5okie this is good to go, merge ahead when ready to move forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Update Build & Deploy Development workflow
trust-over-ip-configurationsrepo with chart/app version and image tag as necessary- Update Helm Chart Release workflow
- Miscellaneous
- Note
When updating the Helm chart default values, changes must be merged into
trust-over-ip-configurationsrepo before merging a PR in this repo.Addresses #1198
Part of bcgov/DITP-DevOps#158 (comment)