Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize docker host IP script. #189

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

WadeBarnes
Copy link
Member

  • This is an update to the previous commit to update the support for Docker networking. The getDockerHost has been pulled out and placed in a central location where it can be updated as needed rather than having to update dozens of scripts the next time there is a change.

Signed-off-by: Wade Barnes wade@neoterictech.ca

- This is an update to the previous commit to update the support for Docker networking.  The `getDockerHost` has been pulled out and placed in a central location where it can be updated as needed rather than having to update dozens of scripts the next time there is a change.

Signed-off-by: Wade Barnes <wade@neoterictech.ca>
@WadeBarnes WadeBarnes requested review from swcurran and ianco December 8, 2021 18:32
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of this approach as mentioned in my AATH comment, but at least this one is all within BC Gov. I think it is a bit to obscure of an approach.

@swcurran swcurran merged commit 4fd4702 into bcgov:main Dec 8, 2021
WadeBarnes pushed a commit to WadeBarnes/von-network that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants