Add workaround for Arm based MACs #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Auto-detect Arm based MAC and set `DOCKER_DEFAULT_PLATFORM=linux/amd64` to ensure docker uses amd64 emulation and uses the available base images. - This is required since there are no Arm based base images for the project currently. Signed-off-by: Wade Barnes <wade@neoterictech.ca>
|
I don't have an Arm based MAC to test this on, so it would be nice if the changes could be tested by someone that does. Thanks |
This was referenced Jul 19, 2023
Closed
|
@andrewwhitehead — can you try this? Basically, on the current release, run:
I might get to it, but I use my Mac as a display machine only — all my development tools are on another machine. I’d rather not add a pile of things to this one... |
esune
approved these changes
Aug 8, 2023
|
Tested on M1 Mac, works as expected. |
WadeBarnes
pushed a commit
to WadeBarnes/von-network
that referenced
this pull request
Aug 28, 2024
Add workaround for Arm based MACs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOCKER_DEFAULT_PLATFORM=linux/amd64to ensure docker uses amd64 emulation and uses the available base images.