Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for transcriptome and metagenome modes #230

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

lcoombe
Copy link
Member

@lcoombe lcoombe commented Oct 2, 2024

  • Fix missing aligner variable in metagenome mode
  • Fix return value when q_mode is True for function primary_and_unaligned_chimeric in get_primary_sam.py
  • Check for and skip secondary alignments in base quality characterization
  • If the homopolymer length modelling doesn't converge, detect this and raise a more informative error
  • Remove --chimeric from transcriptome characterization to keep consistency with simulation options
  • Remove homopolymer characterization/simulation from metagenome mode
    • In many tests, there wasn't enough data for the model to converge, leading to errors
    • The options are still available for advanced users, just will not be advertised in the help page

@lcoombe lcoombe merged commit ad42f92 into master Oct 2, 2024
@lcoombe lcoombe deleted the transcriptome_metagenome_fixes branch October 2, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant