Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change support for MAVIS input in summary module #336

Merged
merged 18 commits into from
Nov 9, 2022

Conversation

zhemingfan
Copy link
Collaborator

Addresses issues in #307

@zhemingfan zhemingfan added this to the v3.1.0 milestone Oct 18, 2022
@zhemingfan zhemingfan requested a review from creisle October 18, 2022 20:30
@zhemingfan zhemingfan self-assigned this Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 86.81% // Head: 86.92% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (bfdf8b7) compared to base (ec82b70).
Patch coverage: 95.94% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff               @@
##           develop_v3     #336      +/-   ##
==============================================
+ Coverage       86.81%   86.92%   +0.10%     
==============================================
  Files              57       57              
  Lines            9327     9390      +63     
  Branches         2335     2355      +20     
==============================================
+ Hits             8097     8162      +65     
+ Misses            755      752       -3     
- Partials          475      476       +1     
Flag Coverage Δ
unittests 86.92% <95.94%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mavis/summary/main.py 77.30% <ø> (ø)
src/mavis/summary/summary.py 70.00% <93.18%> (+5.41%) ⬆️
src/mavis/annotate/file_io.py 77.06% <100.00%> (+0.65%) ⬆️
src/mavis/constants.py 96.72% <100.00%> (+0.02%) ⬆️
src/mavis/pairing/pairing.py 89.86% <100.00%> (+0.13%) ⬆️
src/mavis/util.py 80.07% <0.00%> (+1.42%) ⬆️
src/mavis/cluster/cluster.py 92.10% <0.00%> (+2.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhemingfan
Copy link
Collaborator Author

The version of tabulate has been frozen to version 0.8.9 according to the fix suggested in the Snakemake repository.

src/mavis/summary/summary.py Outdated Show resolved Hide resolved
src/tools/convert_dgv.py Outdated Show resolved Hide resolved
src/tools/convert_dgv.py Outdated Show resolved Hide resolved
tests/test_tools/test_convert_dgv.py Outdated Show resolved Hide resolved
tests/test_mavis/summary/test_summary.py Outdated Show resolved Hide resolved
src/mavis/summary/summary.py Outdated Show resolved Hide resolved
src/mavis/summary/summary.py Outdated Show resolved Hide resolved
src/mavis/summary/summary.py Outdated Show resolved Hide resolved
@zhemingfan zhemingfan requested a review from creisle November 2, 2022 18:17
src/mavis/summary/summary.py Outdated Show resolved Hide resolved
src/mavis/summary/summary.py Outdated Show resolved Hide resolved
src/mavis/summary/summary.py Outdated Show resolved Hide resolved
src/mavis/pairing/pairing.py Outdated Show resolved Hide resolved
src/tools/convert_dgv.py Show resolved Hide resolved
tests/full-tutorial.config.json Outdated Show resolved Hide resolved
tests/test_tools/test_convert_dgv.py Outdated Show resolved Hide resolved
tests/test_tools/test_convert_dgv.py Outdated Show resolved Hide resolved
@creisle
Copy link
Member

creisle commented Nov 2, 2022

Can you also add a description of the new column here? docs/outputs/columns.md

@zhemingfan
Copy link
Collaborator Author

Can you also add a description of the new column here? docs/outputs/columns.md

Added column information in the columns 960bd67.

src/mavis/annotate/file_io.py Outdated Show resolved Hide resolved
src/mavis/annotate/file_io.py Outdated Show resolved Hide resolved
src/mavis/pairing/pairing.py Outdated Show resolved Hide resolved
src/mavis/summary/summary.py Outdated Show resolved Hide resolved
src/mavis/summary/summary.py Outdated Show resolved Hide resolved
src/mavis/summary/summary.py Outdated Show resolved Hide resolved
src/mavis/summary/summary.py Outdated Show resolved Hide resolved
src/mavis/summary/summary.py Show resolved Hide resolved
src/mavis/summary/summary.py Outdated Show resolved Hide resolved
tests/test_tools/test_convert_dgv.py Outdated Show resolved Hide resolved
@zhemingfan zhemingfan requested a review from creisle November 2, 2022 22:41
@creisle creisle requested a review from mattdoug604 November 3, 2022 17:26
src/mavis/annotate/file_io.py Outdated Show resolved Hide resolved
src/mavis/annotate/file_io.py Outdated Show resolved Hide resolved
src/mavis/annotate/file_io.py Show resolved Hide resolved
src/mavis/pairing/pairing.py Show resolved Hide resolved
src/mavis/summary/summary.py Show resolved Hide resolved
src/mavis/summary/summary.py Outdated Show resolved Hide resolved
tests/test_tools/test_convert_dgv.py Outdated Show resolved Hide resolved
src/tools/convert_dgv.py Outdated Show resolved Hide resolved
@mattdoug604 mattdoug604 requested a review from calchoo November 3, 2022 22:44
@zhemingfan zhemingfan requested a review from creisle November 5, 2022 02:15
@zhemingfan zhemingfan merged commit 9624fef into develop_v3 Nov 9, 2022
@zhemingfan zhemingfan deleted the feature/MAVIS-summary-update branch November 9, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants