Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix to Summary module clustering output #337

Merged
merged 7 commits into from
Nov 1, 2022

Conversation

zhemingfan
Copy link
Collaborator

Bugfix in this module is targeted for two issues:

  1. Currently, no structural variants are merged in Summary if the sorted test file (mock_dgv_annotations.txt) is provided given an exact coordinate of the variant dgv1n82. This occurs because we calculate dist = Interval((dgv_region.start), bpp.break1). Given the first entry to be 1 1 2300000 nsv482937 and a BPP with a breakpoint1 of 10001. This dist will almost always be larger than the lowest_resolution + distance, resulting in breaking out of the loop for a particular chr, missing out on any downstream SVs on the same chr.

  2. Multiple SV matches on one call are being overwritten.

@zhemingfan zhemingfan requested a review from creisle November 1, 2022 21:16
@zhemingfan zhemingfan self-assigned this Nov 1, 2022
@zhemingfan zhemingfan added the bug label Nov 1, 2022
@zhemingfan zhemingfan added this to the v3.1.0 milestone Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 86.53% // Head: 86.67% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (8b932a6) compared to base (38d07c4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff               @@
##           develop_v3     #337      +/-   ##
==============================================
+ Coverage       86.53%   86.67%   +0.14%     
==============================================
  Files              57       57              
  Lines            9340     9342       +2     
  Branches         2407     2342      -65     
==============================================
+ Hits             8082     8097      +15     
+ Misses            775      763      -12     
+ Partials          483      482       -1     
Flag Coverage Δ
unittests 86.67% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mavis/summary/summary.py 64.58% <100.00%> (+9.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhemingfan zhemingfan requested a review from creisle November 1, 2022 22:35
@zhemingfan zhemingfan merged commit 8eb2929 into develop_v3 Nov 1, 2022
@zhemingfan zhemingfan deleted the bugfix/MAVIS_summary_clustering branch November 1, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants