Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/kbdev 1133 incorrect matching #108

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

mathieulemieux
Copy link
Member

@mathieulemieux mathieulemieux commented Nov 20, 2023

See https://www.bcgsc.ca/jira/browse/KBDEV-1133.

Introducing type filterring earlier in the matching process.
Had to refactor the structural variant screening.

This PR is fixing the "wrong type" issue regarding matching same position. A workaround makes sure that delins will still be matched to the more specific types deletion or insertion.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6114071) 90.33% compared to head (6771fb4) 90.43%.
Report is 17 commits behind head on master.

❗ Current head 6771fb4 differs from pull request most recent head a7465b9. Consider uploading reports for the commit a7465b9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   90.33%   90.43%   +0.10%     
==========================================
  Files           8        8              
  Lines         838      847       +9     
==========================================
+ Hits          757      766       +9     
  Misses         81       81              
Flag Coverage Δ
unittests 90.43% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant