-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/kbdev 1133 incorrect matching #108
base: master
Are you sure you want to change the base?
Conversation
Merge back master into develop
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 90.33% 90.43% +0.10%
==========================================
Files 8 8
Lines 838 847 +9
==========================================
+ Hits 757 766 +9
Misses 81 81
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
See https://www.bcgsc.ca/jira/browse/KBDEV-1133.
Introducing type filterring earlier in the matching process.
Had to refactor the structural variant screening.
This PR is fixing the "wrong type" issue regarding matching same position. A workaround makes sure that delins will still be matched to the more specific types deletion or insertion.