Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes signature encoding #37

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Fixes signature encoding #37

merged 4 commits into from
Jan 16, 2024

Conversation

Kuly14
Copy link
Contributor

@Kuly14 Kuly14 commented Jan 12, 2024

Not sure if this is correct, will have to test it further

@Kuly14 Kuly14 requested a review from error2215 January 12, 2024 11:03
error2215
error2215 reviewed Jan 13, 2024
View reviewed changes
Copy link
Contributor

@error2215 error2215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to run foxar test and unfortunately it returns same Revert Error

@Kuly14 Kuly14 merged commit c76798a into master Jan 16, 2024
18 of 20 checks passed
@Kuly14 Kuly14 deleted the david/fix-encoding branch January 16, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@error2215 error2215 error2215 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kuly14 @error2215