Update runc to 1.1.0 to get newer x/sys and fix Go 1.18 build #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Due to the outdated indirect golang.org/x/sys dependency the build is broken on Darwin with Go 1.18.
See for example: https://github.com/Homebrew/homebrew-core/runs/5508152735?check_suite_focus=true#step:10:6143
Changes
github.com/opencontainers/runc
dependency to v1.1.0Not having any experience with the Go library, I tried my best to fix it up. Which was essentially: Removing the cgroupManager from the call from
libcontainer.New()
because it no longer fits there, and appears to be handled behind the scenes now.cimg/go
, which is the replacement for the deprecatedcircleci/golang
image: https://circleci.com/developer/images/image/cimg/go and https://circleci.com/docs/2.0/circleci-images/While runc says it only works with Go 1.16+, basic testing with an image built from the Dockerfile shows that it still works fine at 1.15, so I left the go directive as is for now. But issues might turn up that require bumping it to 1.16 or even 1.17.