Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitAttributes file to clean up composer installs #3831

Merged
merged 4 commits into from
May 12, 2015
Merged

GitAttributes file to clean up composer installs #3831

merged 4 commits into from
May 12, 2015

Conversation

lonnieezell
Copy link
Contributor

This basically just removes a number of development-only files (like the user guide source and our tests) from any installs made through composer with the --prefer-dist flag set.

Helps create a faster install with less unnecessary files to new projects.

@narfbg
Copy link
Contributor

narfbg commented May 4, 2015

Not sure about readme.rst and tests/codeigniter/ ... the whole tests/ directory is kinda useless without the latter.

Speaking of directories ... can we not use the word "folders" please? :)

@lonnieezell
Copy link
Contributor Author

My main reason for removing the /codeigniter folder and leaving the rest is that I thought the mocks directory :) would be helpful for people developing their applications to have, but they didn't necessarily need all of our tests in their application.

And I don't have a strong opinion one way or the other about the readme file so I'm fine keeping that.

Let me know final consensus on the tests (which I've just been reading through comments when Symfony went through this a while back and the opinions are definitely mixed) and I'll fix it up.

@narfbg
Copy link
Contributor

narfbg commented May 4, 2015

Oh, I thought the readme files was also ignored ... should look more carefully.

Still unsure about the tests though.

@lonnieezell
Copy link
Contributor Author

As for tests - I guess it comes down to use-case. When we pull down a copy of the repo to start a new project with, do we need CI's tests? On one hand, it can be helpful to look at the existing tests for a reference, but you're not typically going to want to run CI's test suite whenever you run your own tests.

If people want to ensure they get the tests, which I think would be in the minority, then they can always do a git clone, or use --prefer-source with a composer install.

Obviously, I don't think they need to be in there but don't have a strong opinion either way. I can always add some docs that specify how to do both?

@jim-parry @benedmunds What do you guys think on this one?

@benedmunds
Copy link
Contributor

I'd vote for not including the tests.

narfbg added a commit that referenced this pull request May 12, 2015
GitAttributes file to clean up composer installs
@narfbg narfbg merged commit 5bd7e01 into bcit-ci:develop May 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants