Fixed some psalm errors (and some are ignored as Client is bunny stuff)

bckp · Feb 12, 2024 · d934ab9 · d934ab9
1 parent 00901ff
commit d934ab9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/psalm.xml b/psalm.xml
@@ -2,6 +2,8 @@
 <psalm
     errorLevel="2"
     resolveFromConfigFile="true"
+	findUnusedBaselineEntry="false"
+	findUnusedCode="false"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
@@ -10,6 +12,7 @@
         <directory name="src" />
         <ignoreFiles>
             <directory name="vendor" />
+			<file name="src/Connection/Client.php" />
         </ignoreFiles>
     </projectFiles>
 </psalm>
diff --git a/src/Connection/Api.php b/src/Connection/Api.php
@@ -71,10 +71,10 @@ public function createFederation(
 			'exchange' => $name,
 		];
 
-		if ($messageTTL) {
+		if ($messageTTL !== null && $messageTTL > 0) {
 			$federationParamsPrototype['message-ttl'] = $messageTTL;
 		}
-		if ($expires) {
+		if ($expires !== null && $expires > 0) {
 			$federationParamsPrototype['expires'] = $expires;
 		}
 
@@ -167,7 +167,7 @@ private function request(string $method, string $url, array $params = []): array
 
 		return [
 			'status' => $info['http_code'],
-			'data' => $response ? json_decode((string) $response, flags: JSON_THROW_ON_ERROR) : '',
+			'data' => $response !== false ? json_decode((string) $response, flags: JSON_THROW_ON_ERROR) : '',
 		];
 	}