Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): lower base mainnet cache update time #755

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

TheDivic
Copy link
Collaborator

@TheDivic TheDivic commented Dec 6, 2024

📖 Context

Type of change

  • Non-breaking change (backwards compatible)

Why are we doing this?

  • Significant spikes yesterday caused overcharging our clients, we need to cache more often

What did we do?

  • Lowered the base mainnet cache time from 60s to 10s
  • I also changed the RPC provider from Ankr to Alchemy in the production config (not visible in this PR)
  • ⚠️ This will cause 6x more RPC requests to the provider, increasing our credit usage

How Has This Been Tested?

  • Ran local e2e tests

👀 How do I review this?

  • It's a tiny config change, nothing to review

Significant spikes yesterday caused overcharging our clients, we need to cache more often

BREAKING CHANGE: This will cause 6x more request to the RPC provider
@TheDivic TheDivic requested a review from fichiokaku December 6, 2024 08:02
@TheDivic TheDivic self-assigned this Dec 6, 2024
@TheDivic TheDivic added the 🧹 Chore Catch-all label for all boring tasks that can't be classified into any other category label Dec 6, 2024
@TheDivic TheDivic merged commit 6697de8 into master Dec 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Chore Catch-all label for all boring tasks that can't be classified into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants